jason/mempalace
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: harden repair backup scope and migrate swap rollback

Browse Source 
- repair.py: define backup_path before the conditional block so it is
  always in scope when the except handler references it
- migrate.py: restore old palace from .old if both os.rename and
  shutil.move fail during the swap step
This commit is contained in:
JunghwanNA
2026-04-16 14:04:26 +09:00
parent 5dfe853154
commit fb1cf53919
2 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mempalace/migrate.py
+5 -2
View File
@@ -239,8 +239,11 @@ def migrate(palace_path: str, dry_run: bool = False, confirm: bool = False):
try: try:
os.rename(temp_palace, palace_path) os.rename(temp_palace, palace_path)
except OSError: except OSError:
# os.rename fails across filesystems; fall back to move try:
shutil.move(temp_palace, palace_path) shutil.move(temp_palace, palace_path)
except Exception:
os.rename(stale_path, palace_path)
raise
shutil.rmtree(stale_path, ignore_errors=True) shutil.rmtree(stale_path, ignore_errors=True)
print("\n Migration complete.") print("\n Migration complete.")
mempalace/repair.py
+1 -1
View File
@@ -254,8 +254,8 @@ def rebuild_index(palace_path=None):
# Back up ONLY the SQLite database, not the bloated HNSW files # Back up ONLY the SQLite database, not the bloated HNSW files
sqlite_path = os.path.join(palace_path, "chroma.sqlite3") sqlite_path = os.path.join(palace_path, "chroma.sqlite3")
backup_path = sqlite_path + ".backup"
if os.path.exists(sqlite_path): if os.path.exists(sqlite_path):
backup_path = sqlite_path + ".backup"
print(f" Backing up chroma.sqlite3 ({os.path.getsize(sqlite_path) / 1e6:.0f} MB)...") print(f" Backing up chroma.sqlite3 ({os.path.getsize(sqlite_path) / 1e6:.0f} MB)...")
shutil.copy2(sqlite_path, backup_path) shutil.copy2(sqlite_path, backup_path)
print(f" Backup: {backup_path}") print(f" Backup: {backup_path}")