mvalentsev
1d3eecbf9d
Add `mempalace sync` CLI command and `mempalace_sync` MCP tool that prune drawers whose source files are gitignored, deleted, or moved out of the project. Reuses the existing GitignoreMatcher infrastructure in mempalace/miner.py so the same gitignore rules that block ingest also drive the corresponding cleanup. Closes #1252.
1129 lines
40 KiB
Python
1129 lines
40 KiB
Python
"""
|
|
test_sync.py — Tests for `mempalace.sync` (gitignore-aware drawer prune, #1252).
|
|
|
|
Builds a focused fixture: a temp project with .gitignore + on-disk files +
|
|
matching drawers, exercising every classification bucket sync produces.
|
|
"""
|
|
|
|
import os
|
|
from pathlib import Path
|
|
|
|
import chromadb
|
|
import pytest
|
|
|
|
|
|
def _seed_drawers(palace_path, repo_path, deleted_path):
|
|
"""Populate the drawers collection with 6 entries covering all buckets."""
|
|
client = chromadb.PersistentClient(path=palace_path)
|
|
col = client.get_or_create_collection("mempalace_drawers", metadata={"hnsw:space": "cosine"})
|
|
|
|
metas = [
|
|
{
|
|
"wing": "demo",
|
|
"room": "src",
|
|
"source_file": str(repo_path / "src" / "keep.py"),
|
|
"chunk_index": 0,
|
|
"added_by": "miner",
|
|
"filed_at": "2026-05-09T00:00:00",
|
|
},
|
|
{
|
|
"wing": "demo",
|
|
"room": "build",
|
|
"source_file": str(repo_path / "build" / "ignored.py"),
|
|
"chunk_index": 0,
|
|
"added_by": "miner",
|
|
"filed_at": "2026-05-09T00:00:00",
|
|
},
|
|
{
|
|
"wing": "demo",
|
|
"room": "logs",
|
|
"source_file": str(repo_path / "app.log"),
|
|
"chunk_index": 0,
|
|
"added_by": "miner",
|
|
"filed_at": "2026-05-09T00:00:00",
|
|
},
|
|
{
|
|
"wing": "demo",
|
|
"room": "stale",
|
|
"source_file": str(deleted_path),
|
|
"chunk_index": 0,
|
|
"added_by": "miner",
|
|
"filed_at": "2026-05-09T00:00:00",
|
|
},
|
|
{
|
|
"wing": "demo",
|
|
"room": "convo",
|
|
# No source_file key — convo / explicit-add drawers.
|
|
"chunk_index": 0,
|
|
"added_by": "convo_miner",
|
|
"filed_at": "2026-05-09T00:00:00",
|
|
},
|
|
{
|
|
"wing": "demo",
|
|
"room": "elsewhere",
|
|
"source_file": "/tmp/elsewhere/x.md",
|
|
"chunk_index": 0,
|
|
"added_by": "miner",
|
|
"filed_at": "2026-05-09T00:00:00",
|
|
},
|
|
]
|
|
|
|
col.add(
|
|
ids=[
|
|
"drawer_keep",
|
|
"drawer_gitignored_dir",
|
|
"drawer_gitignored_glob",
|
|
"drawer_missing",
|
|
"drawer_no_source",
|
|
"drawer_out_of_scope",
|
|
],
|
|
documents=[f"doc {i}" for i in range(6)],
|
|
embeddings=[[float(i + 1), 0.0, 0.0] for i in range(6)],
|
|
metadatas=metas,
|
|
)
|
|
del client
|
|
|
|
|
|
@pytest.fixture
|
|
def synced_world(tmp_dir, palace_path):
|
|
"""Temp project with .gitignore + on-disk files + matching drawers."""
|
|
repo_path = Path(tmp_dir) / "repo"
|
|
(repo_path / "src").mkdir(parents=True)
|
|
(repo_path / "build").mkdir()
|
|
|
|
# .gitignore: ignore build/ directory and any *.log file
|
|
(repo_path / ".gitignore").write_text("build/\n*.log\n")
|
|
|
|
# Files that exist on disk
|
|
(repo_path / "src" / "keep.py").write_text("# keep\n")
|
|
(repo_path / "build" / "ignored.py").write_text("# ignored by gitignore\n")
|
|
(repo_path / "app.log").write_text("log line\n")
|
|
|
|
# File that the drawer points to but no longer exists
|
|
deleted = repo_path / "deleted.py"
|
|
deleted.write_text("# was here\n")
|
|
deleted.unlink()
|
|
|
|
_seed_drawers(palace_path, repo_path, deleted)
|
|
return {"palace_path": palace_path, "repo_path": str(repo_path)}
|
|
|
|
|
|
def _open_drawers(palace_path):
|
|
client = chromadb.PersistentClient(path=palace_path)
|
|
col = client.get_or_create_collection("mempalace_drawers", metadata={"hnsw:space": "cosine"})
|
|
return client, col
|
|
|
|
|
|
def _drawer_ids(col):
|
|
return set(col.get(include=[])["ids"])
|
|
|
|
|
|
class TestSyncPalace:
|
|
def test_dry_run_classifies_correctly(self, synced_world):
|
|
from mempalace.sync import sync_palace
|
|
|
|
report = sync_palace(
|
|
palace_path=synced_world["palace_path"],
|
|
project_dirs=[synced_world["repo_path"]],
|
|
dry_run=True,
|
|
)
|
|
assert report["scanned"] == 6
|
|
assert report["gitignored"] == 2 # build/ignored.py, app.log
|
|
assert report["missing"] == 1 # deleted.py
|
|
assert report["no_source"] == 1
|
|
assert report["out_of_scope"] == 1
|
|
assert report["kept"] == 1 # only src/keep.py
|
|
assert report["dry_run"] is True
|
|
assert report["removed_drawers"] == 0
|
|
|
|
# Mutation check — collection still has all 6 drawers.
|
|
client, col = _open_drawers(synced_world["palace_path"])
|
|
try:
|
|
assert len(_drawer_ids(col)) == 6
|
|
finally:
|
|
del client
|
|
|
|
def test_apply_removes_gitignored_and_missing(self, synced_world):
|
|
from mempalace.sync import sync_palace
|
|
|
|
report = sync_palace(
|
|
palace_path=synced_world["palace_path"],
|
|
project_dirs=[synced_world["repo_path"]],
|
|
dry_run=False,
|
|
)
|
|
assert report["dry_run"] is False
|
|
assert report["removed_drawers"] == 3 # 2 gitignored + 1 missing
|
|
|
|
client, col = _open_drawers(synced_world["palace_path"])
|
|
try:
|
|
survivors = _drawer_ids(col)
|
|
assert survivors == {
|
|
"drawer_keep",
|
|
"drawer_no_source",
|
|
"drawer_out_of_scope",
|
|
}
|
|
finally:
|
|
del client
|
|
|
|
def test_dry_run_does_not_touch_collection(self, synced_world):
|
|
from mempalace.sync import sync_palace
|
|
|
|
client, col = _open_drawers(synced_world["palace_path"])
|
|
before = _drawer_ids(col)
|
|
del client
|
|
|
|
sync_palace(
|
|
palace_path=synced_world["palace_path"],
|
|
project_dirs=[synced_world["repo_path"]],
|
|
dry_run=True,
|
|
)
|
|
|
|
client, col = _open_drawers(synced_world["palace_path"])
|
|
try:
|
|
after = _drawer_ids(col)
|
|
finally:
|
|
del client
|
|
assert before == after
|
|
|
|
def test_wing_scope_filters(self, tmp_dir, palace_path):
|
|
"""A drawer in another wing must survive a wing-scoped sync."""
|
|
from mempalace.sync import sync_palace
|
|
|
|
repo_path = Path(tmp_dir) / "repo"
|
|
(repo_path / "build").mkdir(parents=True)
|
|
(repo_path / ".gitignore").write_text("build/\n")
|
|
(repo_path / "build" / "ignored.py").write_text("# ignored\n")
|
|
|
|
client = chromadb.PersistentClient(path=palace_path)
|
|
col = client.get_or_create_collection(
|
|
"mempalace_drawers", metadata={"hnsw:space": "cosine"}
|
|
)
|
|
col.add(
|
|
ids=["d_demo", "d_other"],
|
|
documents=["x", "y"],
|
|
embeddings=[[1.0, 0.0, 0.0], [2.0, 0.0, 0.0]],
|
|
metadatas=[
|
|
{
|
|
"wing": "demo",
|
|
"room": "build",
|
|
"source_file": str(repo_path / "build" / "ignored.py"),
|
|
"chunk_index": 0,
|
|
"added_by": "miner",
|
|
"filed_at": "2026-05-09T00:00:00",
|
|
},
|
|
{
|
|
"wing": "other",
|
|
"room": "build",
|
|
"source_file": str(repo_path / "build" / "ignored.py"),
|
|
"chunk_index": 0,
|
|
"added_by": "miner",
|
|
"filed_at": "2026-05-09T00:00:00",
|
|
},
|
|
],
|
|
)
|
|
del client
|
|
|
|
sync_palace(
|
|
palace_path=palace_path,
|
|
project_dirs=[str(repo_path)],
|
|
wing="demo",
|
|
dry_run=False,
|
|
)
|
|
|
|
client, col = _open_drawers(palace_path)
|
|
try:
|
|
assert _drawer_ids(col) == {"d_other"}
|
|
finally:
|
|
del client
|
|
|
|
def test_no_source_file_drawers_preserved_on_apply(self, synced_world):
|
|
from mempalace.sync import sync_palace
|
|
|
|
sync_palace(
|
|
palace_path=synced_world["palace_path"],
|
|
project_dirs=[synced_world["repo_path"]],
|
|
dry_run=False,
|
|
)
|
|
client, col = _open_drawers(synced_world["palace_path"])
|
|
try:
|
|
assert "drawer_no_source" in _drawer_ids(col)
|
|
finally:
|
|
del client
|
|
|
|
def test_out_of_scope_drawers_preserved(self, synced_world):
|
|
from mempalace.sync import sync_palace
|
|
|
|
sync_palace(
|
|
palace_path=synced_world["palace_path"],
|
|
project_dirs=[synced_world["repo_path"]],
|
|
dry_run=False,
|
|
)
|
|
client, col = _open_drawers(synced_world["palace_path"])
|
|
try:
|
|
assert "drawer_out_of_scope" in _drawer_ids(col)
|
|
finally:
|
|
del client
|
|
|
|
def test_negated_gitignore_rules_respected(self, tmp_dir, palace_path):
|
|
"""`!build/keep.py` must un-ignore one specific file under build/."""
|
|
from mempalace.sync import sync_palace
|
|
|
|
repo_path = Path(tmp_dir) / "repo"
|
|
(repo_path / "build").mkdir(parents=True)
|
|
(repo_path / ".gitignore").write_text("build/\n!build/keep.py\n")
|
|
(repo_path / "build" / "keep.py").write_text("# survivor\n")
|
|
(repo_path / "build" / "doomed.py").write_text("# doomed\n")
|
|
|
|
client = chromadb.PersistentClient(path=palace_path)
|
|
col = client.get_or_create_collection(
|
|
"mempalace_drawers", metadata={"hnsw:space": "cosine"}
|
|
)
|
|
col.add(
|
|
ids=["d_keep", "d_doom"],
|
|
documents=["x", "y"],
|
|
embeddings=[[1.0, 0.0, 0.0], [2.0, 0.0, 0.0]],
|
|
metadatas=[
|
|
{
|
|
"wing": "demo",
|
|
"room": "build",
|
|
"source_file": str(repo_path / "build" / "keep.py"),
|
|
"chunk_index": 0,
|
|
"added_by": "miner",
|
|
"filed_at": "2026-05-09T00:00:00",
|
|
},
|
|
{
|
|
"wing": "demo",
|
|
"room": "build",
|
|
"source_file": str(repo_path / "build" / "doomed.py"),
|
|
"chunk_index": 0,
|
|
"added_by": "miner",
|
|
"filed_at": "2026-05-09T00:00:00",
|
|
},
|
|
],
|
|
)
|
|
del client
|
|
|
|
sync_palace(
|
|
palace_path=palace_path,
|
|
project_dirs=[str(repo_path)],
|
|
dry_run=False,
|
|
)
|
|
|
|
client, col = _open_drawers(palace_path)
|
|
try:
|
|
survivors = _drawer_ids(col)
|
|
finally:
|
|
del client
|
|
assert "d_keep" in survivors
|
|
assert "d_doom" not in survivors
|
|
|
|
def test_nested_gitignore_layers(self, tmp_dir, palace_path):
|
|
"""Subdir .gitignore can deny what root allows."""
|
|
from mempalace.sync import sync_palace
|
|
|
|
repo_path = Path(tmp_dir) / "repo"
|
|
(repo_path / "vendor").mkdir(parents=True)
|
|
# Root gitignore is empty.
|
|
(repo_path / ".gitignore").write_text("\n")
|
|
# Subdir gitignore ignores everything under vendor/.
|
|
(repo_path / "vendor" / ".gitignore").write_text("*.py\n")
|
|
(repo_path / "vendor" / "lib.py").write_text("# nested-ignored\n")
|
|
|
|
client = chromadb.PersistentClient(path=palace_path)
|
|
col = client.get_or_create_collection(
|
|
"mempalace_drawers", metadata={"hnsw:space": "cosine"}
|
|
)
|
|
col.add(
|
|
ids=["d_nested"],
|
|
documents=["x"],
|
|
embeddings=[[1.0, 0.0, 0.0]],
|
|
metadatas=[
|
|
{
|
|
"wing": "demo",
|
|
"room": "vendor",
|
|
"source_file": str(repo_path / "vendor" / "lib.py"),
|
|
"chunk_index": 0,
|
|
"added_by": "miner",
|
|
"filed_at": "2026-05-09T00:00:00",
|
|
}
|
|
],
|
|
)
|
|
del client
|
|
|
|
sync_palace(
|
|
palace_path=palace_path,
|
|
project_dirs=[str(repo_path)],
|
|
dry_run=False,
|
|
)
|
|
|
|
client, col = _open_drawers(palace_path)
|
|
try:
|
|
assert "d_nested" not in _drawer_ids(col)
|
|
finally:
|
|
del client
|
|
|
|
def test_closet_purge_runs_on_apply(self, synced_world):
|
|
"""Closets pointing at removed sources must also disappear."""
|
|
from mempalace.sync import sync_palace
|
|
|
|
# Seed a closet referencing the to-be-pruned ignored.py source.
|
|
client = chromadb.PersistentClient(path=synced_world["palace_path"])
|
|
closets = client.get_or_create_collection(
|
|
"mempalace_closets", metadata={"hnsw:space": "cosine"}
|
|
)
|
|
ignored_path = str(Path(synced_world["repo_path"]) / "build" / "ignored.py")
|
|
closets.add(
|
|
ids=["closet_ignored_01"],
|
|
documents=["topic line"],
|
|
embeddings=[[1.0, 0.0, 0.0]],
|
|
metadatas=[
|
|
{
|
|
"wing": "demo",
|
|
"room": "build",
|
|
"source_file": ignored_path,
|
|
"chunk_index": 0,
|
|
"added_by": "miner",
|
|
"filed_at": "2026-05-09T00:00:00",
|
|
}
|
|
],
|
|
)
|
|
del client
|
|
|
|
report = sync_palace(
|
|
palace_path=synced_world["palace_path"],
|
|
project_dirs=[synced_world["repo_path"]],
|
|
dry_run=False,
|
|
)
|
|
assert report["removed_closets"] >= 1
|
|
|
|
client = chromadb.PersistentClient(path=synced_world["palace_path"])
|
|
closets = client.get_or_create_collection(
|
|
"mempalace_closets", metadata={"hnsw:space": "cosine"}
|
|
)
|
|
try:
|
|
assert closets.get(ids=["closet_ignored_01"])["ids"] == []
|
|
finally:
|
|
del client
|
|
|
|
def test_handles_empty_palace(self, palace_path):
|
|
from mempalace.sync import sync_palace
|
|
|
|
client = chromadb.PersistentClient(path=palace_path)
|
|
client.get_or_create_collection("mempalace_drawers", metadata={"hnsw:space": "cosine"})
|
|
del client
|
|
|
|
report = sync_palace(palace_path=palace_path, dry_run=True)
|
|
assert report["scanned"] == 0
|
|
assert report["removed_drawers"] == 0
|
|
|
|
def test_emits_wal_entries_on_apply(self, synced_world):
|
|
from mempalace.sync import sync_palace
|
|
|
|
seen = []
|
|
|
|
def fake_wal(operation, params, result=None):
|
|
seen.append((operation, params, result))
|
|
|
|
sync_palace(
|
|
palace_path=synced_world["palace_path"],
|
|
project_dirs=[synced_world["repo_path"]],
|
|
dry_run=False,
|
|
wal_log=fake_wal,
|
|
)
|
|
|
|
ops = [op for op, _, _ in seen]
|
|
assert "sync_prune" in ops
|
|
# F4 — result payload carries the audit trail.
|
|
sync_entry = next(e for e in seen if e[0] == "sync_prune")
|
|
op, params, result = sync_entry
|
|
assert result is not None and "removed_count" in result
|
|
assert result["removed_count"] >= 1
|
|
# Allow-list — params must be exactly the documented audit shape so
|
|
# any future leak (source_file, content, ID lists, etc.) trips a
|
|
# test failure rather than slipping through a deny-list.
|
|
assert set(params.keys()) <= {
|
|
"first_id"
|
|
}, f"WAL params drifted from the audit allow-list: {params.keys()}"
|
|
|
|
def test_registry_sentinels_preserved_on_apply(self, tmp_dir, palace_path):
|
|
"""F2 regression: convo miner `_reg_*` sentinels must survive sync apply.
|
|
|
|
Deleting them forces full re-mine + re-embed of the transcript on the
|
|
next miner run, even though the transcript content has not changed.
|
|
"""
|
|
from mempalace.sync import sync_palace
|
|
|
|
repo_path = Path(tmp_dir) / "repo"
|
|
repo_path.mkdir(parents=True)
|
|
(repo_path / ".gitignore").write_text("transcripts/\n")
|
|
(repo_path / "transcripts").mkdir()
|
|
moved_transcript = repo_path / "transcripts" / "convo.jsonl"
|
|
moved_transcript.write_text("{}\n")
|
|
|
|
client = chromadb.PersistentClient(path=palace_path)
|
|
col = client.get_or_create_collection(
|
|
"mempalace_drawers", metadata={"hnsw:space": "cosine"}
|
|
)
|
|
col.add(
|
|
ids=[
|
|
"_reg_abc123_room_match",
|
|
"_reg_def456_meta_match",
|
|
"_reg_ghi789_id_match",
|
|
],
|
|
documents=["[registry] x", "[registry] y", "[registry] z"],
|
|
embeddings=[[1.0, 0.0, 0.0], [2.0, 0.0, 0.0], [3.0, 0.0, 0.0]],
|
|
metadatas=[
|
|
{
|
|
"wing": "demo",
|
|
"room": "_registry",
|
|
"source_file": str(moved_transcript),
|
|
"chunk_index": 0,
|
|
"added_by": "convo_miner",
|
|
"filed_at": "2026-05-09T00:00:00",
|
|
},
|
|
{
|
|
"wing": "demo",
|
|
"room": "convo",
|
|
"source_file": str(moved_transcript),
|
|
"chunk_index": 0,
|
|
"added_by": "convo_miner",
|
|
"filed_at": "2026-05-09T00:00:00",
|
|
"ingest_mode": "registry",
|
|
},
|
|
{
|
|
"wing": "demo",
|
|
"room": "convo",
|
|
"source_file": str(moved_transcript),
|
|
"chunk_index": 0,
|
|
"added_by": "convo_miner",
|
|
"filed_at": "2026-05-09T00:00:00",
|
|
},
|
|
],
|
|
)
|
|
del client
|
|
|
|
# Sentinel transcript is gitignored; without F2 it would also delete
|
|
# the `_reg_*` sentinel rows.
|
|
sync_palace(
|
|
palace_path=palace_path,
|
|
project_dirs=[str(repo_path)],
|
|
dry_run=False,
|
|
)
|
|
|
|
client, col = _open_drawers(palace_path)
|
|
try:
|
|
survivors = _drawer_ids(col)
|
|
finally:
|
|
del client
|
|
assert "_reg_abc123_room_match" in survivors # room=_registry
|
|
assert "_reg_def456_meta_match" in survivors # ingest_mode=registry
|
|
assert "_reg_ghi789_id_match" in survivors # id prefix
|
|
|
|
def test_auto_detect_picks_deepest_root(self, tmp_dir, palace_path):
|
|
"""F3 regression (white-box): when multiple ancestors hold markers
|
|
the DEEPEST one wins. Direct assertion on the helper avoids the
|
|
tautology of round-1's classifier-based test where ancestor walks
|
|
loaded the same matcher chain regardless of which root was picked.
|
|
"""
|
|
from mempalace.sync import _auto_detect_project_roots
|
|
|
|
outer = Path(tmp_dir) / "outer"
|
|
inner = outer / "inner"
|
|
inner.mkdir(parents=True)
|
|
# Both have markers. Deepest wins.
|
|
(outer / ".gitignore").write_text("*.txt\n")
|
|
(inner / ".gitignore").write_text("*.py\n")
|
|
|
|
client = chromadb.PersistentClient(path=palace_path)
|
|
col = client.get_or_create_collection(
|
|
"mempalace_drawers", metadata={"hnsw:space": "cosine"}
|
|
)
|
|
col.add(
|
|
ids=["d_inner"],
|
|
documents=["x"],
|
|
embeddings=[[1.0, 0.0, 0.0]],
|
|
metadatas=[
|
|
{
|
|
"wing": "demo",
|
|
"room": "src",
|
|
"source_file": str(inner / "x.py"),
|
|
"chunk_index": 0,
|
|
"added_by": "miner",
|
|
"filed_at": "2026-05-09T00:00:00",
|
|
}
|
|
],
|
|
)
|
|
del client
|
|
|
|
client, col = _open_drawers(palace_path)
|
|
try:
|
|
roots = _auto_detect_project_roots(col, wing="demo")
|
|
finally:
|
|
del client
|
|
|
|
inner_resolved = inner.resolve(strict=False)
|
|
outer_resolved = outer.resolve(strict=False)
|
|
assert inner_resolved in roots, f"expected inner in roots, got {roots}"
|
|
assert (
|
|
outer_resolved not in roots
|
|
), f"deepest should win exclusively: roots={roots}, outer leaked"
|
|
|
|
def test_apply_with_empty_project_dirs_raises(self, palace_path):
|
|
"""Round-2 P1: `project_dirs=[]` (empty list) with apply must raise,
|
|
not silently classify everything as out_of_scope."""
|
|
from mempalace.sync import sync_palace
|
|
|
|
client = chromadb.PersistentClient(path=palace_path)
|
|
client.get_or_create_collection("mempalace_drawers", metadata={"hnsw:space": "cosine"})
|
|
del client
|
|
|
|
with pytest.raises(ValueError, match="empty"):
|
|
sync_palace(
|
|
palace_path=palace_path,
|
|
project_dirs=[],
|
|
wing="demo",
|
|
dry_run=False,
|
|
)
|
|
|
|
def test_closet_log_warning_when_collection_unavailable(
|
|
self, monkeypatch, synced_world, caplog
|
|
):
|
|
"""F7 regression: closets-collection-missing logs a warning."""
|
|
import logging
|
|
|
|
from mempalace import sync as sync_mod
|
|
from mempalace.sync import sync_palace
|
|
|
|
def boom(*args, **kwargs):
|
|
raise RuntimeError("simulated missing closets collection")
|
|
|
|
monkeypatch.setattr(sync_mod, "get_closets_collection", boom)
|
|
|
|
with caplog.at_level(logging.WARNING, logger="mempalace.sync"):
|
|
sync_palace(
|
|
palace_path=synced_world["palace_path"],
|
|
project_dirs=[synced_world["repo_path"]],
|
|
dry_run=False,
|
|
)
|
|
assert any(
|
|
"Closet purge skipped" in record.getMessage() for record in caplog.records
|
|
), f"expected closet-skip warning, got: {[r.getMessage() for r in caplog.records]}"
|
|
|
|
def test_metadata_cache_cleared_on_exception(self, monkeypatch, config, synced_world, kg):
|
|
"""F9 regression: tool_sync's try/finally must clear `_metadata_cache`
|
|
even if sync_palace raises mid-apply.
|
|
|
|
Tracks an explicit `called` flag on the explode mock so a refactor
|
|
that bypasses the patched name (and lets the real sync_palace run)
|
|
cannot fake-pass — the assertion below verifies the patched explode
|
|
actually ran before the cache was cleared.
|
|
"""
|
|
from mempalace import mcp_server
|
|
|
|
# Reconfigure to point at synced_world.
|
|
from mempalace.config import MempalaceConfig
|
|
import json
|
|
|
|
cfg_dir = Path(synced_world["palace_path"]).parent / "cfg_for_cache_test"
|
|
cfg_dir.mkdir(parents=True, exist_ok=True)
|
|
with open(cfg_dir / "config.json", "w") as f:
|
|
json.dump({"palace_path": synced_world["palace_path"]}, f)
|
|
monkeypatch.setattr(mcp_server, "_config", MempalaceConfig(config_dir=str(cfg_dir)))
|
|
monkeypatch.setattr(mcp_server, "_get_kg", lambda: kg)
|
|
monkeypatch.setattr(mcp_server, "_metadata_cache", ["dirty-cache-marker"])
|
|
|
|
called = {"n": 0}
|
|
|
|
def explode(*args, **kwargs):
|
|
called["n"] += 1
|
|
raise RuntimeError("simulated mid-apply failure")
|
|
|
|
monkeypatch.setattr("mempalace.sync.sync_palace", explode)
|
|
|
|
# tool_sync's broad except catches RuntimeError → returns structured error.
|
|
result = mcp_server.tool_sync(
|
|
project_dir=synced_world["repo_path"], wing="demo", apply=True
|
|
)
|
|
assert called["n"] == 1, "explode mock did not actually run; test is a fake-pass"
|
|
assert result.get("success") is False
|
|
assert "simulated" in result.get("error", "")
|
|
|
|
assert (
|
|
mcp_server._metadata_cache is None
|
|
), "F9: cache must be cleared even when sync_palace raises"
|
|
|
|
def test_sync_report_keys_stable(self, synced_world):
|
|
"""Regression: SyncReport schema must not silently drop a field."""
|
|
from mempalace.sync import sync_palace
|
|
|
|
report = sync_palace(
|
|
palace_path=synced_world["palace_path"],
|
|
project_dirs=[synced_world["repo_path"]],
|
|
dry_run=True,
|
|
)
|
|
expected = {
|
|
"scanned",
|
|
"kept",
|
|
"gitignored",
|
|
"missing",
|
|
"no_source",
|
|
"out_of_scope",
|
|
"removed_drawers",
|
|
"removed_closets",
|
|
"dry_run",
|
|
"by_source",
|
|
}
|
|
assert set(report.keys()) == expected
|
|
|
|
def test_batch_size_boundary(self, tmp_dir, palace_path):
|
|
"""`_delete_in_batches` correctness at batch_size smaller than dataset."""
|
|
from mempalace.sync import sync_palace
|
|
|
|
repo_path = Path(tmp_dir) / "repo"
|
|
repo_path.mkdir(parents=True)
|
|
(repo_path / ".gitignore").write_text("ignored/\n")
|
|
(repo_path / "ignored").mkdir()
|
|
n = 5
|
|
for i in range(n):
|
|
(repo_path / "ignored" / f"f{i}.py").write_text(f"# {i}\n")
|
|
|
|
client = chromadb.PersistentClient(path=palace_path)
|
|
col = client.get_or_create_collection(
|
|
"mempalace_drawers", metadata={"hnsw:space": "cosine"}
|
|
)
|
|
col.add(
|
|
ids=[f"d_{i}" for i in range(n)],
|
|
documents=[f"x{i}" for i in range(n)],
|
|
embeddings=[[float(i + 1), 0.0, 0.0] for i in range(n)],
|
|
metadatas=[
|
|
{
|
|
"wing": "demo",
|
|
"room": "ignored",
|
|
"source_file": str(repo_path / "ignored" / f"f{i}.py"),
|
|
"chunk_index": 0,
|
|
"added_by": "miner",
|
|
"filed_at": "2026-05-09T00:00:00",
|
|
}
|
|
for i in range(n)
|
|
],
|
|
)
|
|
del client
|
|
|
|
seen = []
|
|
|
|
def fake_wal(operation, params, result=None):
|
|
if operation == "sync_prune":
|
|
seen.append(result["removed_count"])
|
|
|
|
report = sync_palace(
|
|
palace_path=palace_path,
|
|
project_dirs=[str(repo_path)],
|
|
wing="demo",
|
|
dry_run=False,
|
|
batch_size=2,
|
|
wal_log=fake_wal,
|
|
)
|
|
assert report["removed_drawers"] == n
|
|
# 5 ids at batch_size=2 → chunks of 2,2,1 → 3 wal entries
|
|
assert seen == [2, 2, 1], f"unexpected chunk sizes: {seen}"
|
|
|
|
def test_apply_is_idempotent(self, synced_world):
|
|
"""Round-3: a second apply on the same palace must be a no-op."""
|
|
from mempalace.sync import sync_palace
|
|
|
|
first = sync_palace(
|
|
palace_path=synced_world["palace_path"],
|
|
project_dirs=[synced_world["repo_path"]],
|
|
dry_run=False,
|
|
)
|
|
assert first["removed_drawers"] >= 1
|
|
|
|
second = sync_palace(
|
|
palace_path=synced_world["palace_path"],
|
|
project_dirs=[synced_world["repo_path"]],
|
|
dry_run=False,
|
|
)
|
|
assert second["removed_drawers"] == 0
|
|
assert second["gitignored"] == 0
|
|
assert second["missing"] == 0
|
|
|
|
def test_relative_source_file_classified_as_no_source(self, tmp_dir, palace_path):
|
|
"""Round-3: a drawer whose source_file metadata is relative is upstream
|
|
corruption (miner writes absolute paths). Sync must NOT guess at
|
|
path resolution; it routes the drawer to `no_source` and leaves it."""
|
|
from mempalace.sync import sync_palace
|
|
|
|
client = chromadb.PersistentClient(path=palace_path)
|
|
col = client.get_or_create_collection(
|
|
"mempalace_drawers", metadata={"hnsw:space": "cosine"}
|
|
)
|
|
col.add(
|
|
ids=["d_relative"],
|
|
documents=["x"],
|
|
embeddings=[[1.0, 0.0, 0.0]],
|
|
metadatas=[
|
|
{
|
|
"wing": "demo",
|
|
"room": "src",
|
|
"source_file": "relative/path.py", # malformed, not absolute
|
|
"chunk_index": 0,
|
|
"added_by": "miner",
|
|
"filed_at": "2026-05-09T00:00:00",
|
|
}
|
|
],
|
|
)
|
|
del client
|
|
|
|
repo_path = Path(tmp_dir) / "repo"
|
|
repo_path.mkdir()
|
|
(repo_path / ".gitignore").write_text("*.py\n")
|
|
|
|
report = sync_palace(
|
|
palace_path=palace_path,
|
|
project_dirs=[str(repo_path)],
|
|
wing="demo",
|
|
dry_run=False,
|
|
)
|
|
assert report["no_source"] == 1
|
|
assert report["removed_drawers"] == 0
|
|
|
|
client, col = _open_drawers(palace_path)
|
|
try:
|
|
assert "d_relative" in _drawer_ids(col)
|
|
finally:
|
|
del client
|
|
|
|
def test_overlapping_project_dirs_picks_longest(self, tmp_dir, palace_path):
|
|
"""`_resolve_project_root` longest-prefix matching: nested project
|
|
dirs both contain the source; the deeper (longer) one wins."""
|
|
from mempalace.sync import sync_palace
|
|
|
|
outer = Path(tmp_dir) / "outer"
|
|
inner = outer / "inner"
|
|
inner.mkdir(parents=True)
|
|
# Outer .gitignore would NOT block file. Inner .gitignore blocks it.
|
|
(outer / ".gitignore").write_text("# empty\n")
|
|
(inner / ".gitignore").write_text("x.py\n")
|
|
(inner / "x.py").write_text("# inner-ignored\n")
|
|
|
|
client = chromadb.PersistentClient(path=palace_path)
|
|
col = client.get_or_create_collection(
|
|
"mempalace_drawers", metadata={"hnsw:space": "cosine"}
|
|
)
|
|
col.add(
|
|
ids=["d_x"],
|
|
documents=["x"],
|
|
embeddings=[[1.0, 0.0, 0.0]],
|
|
metadatas=[
|
|
{
|
|
"wing": "demo",
|
|
"room": "src",
|
|
"source_file": str(inner / "x.py"),
|
|
"chunk_index": 0,
|
|
"added_by": "miner",
|
|
"filed_at": "2026-05-09T00:00:00",
|
|
}
|
|
],
|
|
)
|
|
del client
|
|
|
|
# Pass BOTH outer AND inner as project_dirs. inner is the longest
|
|
# prefix, so it should be the chosen root and inner/.gitignore
|
|
# rules apply (file is ignored → drawer removed).
|
|
report = sync_palace(
|
|
palace_path=palace_path,
|
|
project_dirs=[str(outer), str(inner)],
|
|
wing="demo",
|
|
dry_run=False,
|
|
)
|
|
assert report["gitignored"] == 1, f"expected 1 gitignored, got {report}"
|
|
|
|
def test_apply_without_scope_raises(self, palace_path):
|
|
"""F6: apply=True with both wing=None AND project_dirs=None refuses."""
|
|
from mempalace.sync import sync_palace
|
|
|
|
# Empty palace; we never reach delete code, but the guard must fire
|
|
# before any work.
|
|
client = chromadb.PersistentClient(path=palace_path)
|
|
client.get_or_create_collection("mempalace_drawers", metadata={"hnsw:space": "cosine"})
|
|
del client
|
|
|
|
with pytest.raises(ValueError, match="explicit wing="):
|
|
sync_palace(palace_path=palace_path, dry_run=False)
|
|
|
|
# Dry-run with no scope is still allowed — preview is read-only.
|
|
report = sync_palace(palace_path=palace_path, dry_run=True)
|
|
assert report["dry_run"] is True
|
|
|
|
@pytest.mark.skipif(os.name == "nt", reason="fcntl-based contention test is POSIX only")
|
|
def test_mine_already_running_propagates(self, synced_world):
|
|
"""F1 + T4: sync acquires `mine_palace_lock` for the whole call.
|
|
|
|
Hold the palace lock via raw fcntl on a separate open file
|
|
description; mine_palace_lock opens its own handle and must
|
|
raise MineAlreadyRunning rather than silently running against
|
|
a partial snapshot.
|
|
"""
|
|
import fcntl
|
|
import hashlib
|
|
|
|
from mempalace.palace import MineAlreadyRunning
|
|
from mempalace.sync import sync_palace
|
|
|
|
palace_path = synced_world["palace_path"]
|
|
resolved = os.path.realpath(os.path.expanduser(palace_path))
|
|
palace_key = hashlib.sha256(os.path.normcase(resolved).encode()).hexdigest()[:16]
|
|
lock_dir = os.path.join(os.path.expanduser("~"), ".mempalace", "locks")
|
|
os.makedirs(lock_dir, exist_ok=True)
|
|
lock_path = os.path.join(lock_dir, f"mine_palace_{palace_key}.lock")
|
|
Path(lock_path).touch()
|
|
|
|
with open(lock_path, "r+") as lf:
|
|
fcntl.flock(lf, fcntl.LOCK_EX | fcntl.LOCK_NB)
|
|
try:
|
|
with pytest.raises(MineAlreadyRunning):
|
|
sync_palace(
|
|
palace_path=palace_path,
|
|
project_dirs=[synced_world["repo_path"]],
|
|
dry_run=True,
|
|
)
|
|
finally:
|
|
fcntl.flock(lf, fcntl.LOCK_UN)
|
|
|
|
# Lock released — sync now succeeds.
|
|
sync_palace(
|
|
palace_path=palace_path,
|
|
project_dirs=[synced_world["repo_path"]],
|
|
dry_run=True,
|
|
)
|
|
|
|
|
|
class TestSyncMcpTool:
|
|
"""T2: `mempalace_sync` MCP entry point must keep apply polarity stable."""
|
|
|
|
def _patch(self, monkeypatch, config, kg):
|
|
from mempalace import mcp_server
|
|
|
|
monkeypatch.setattr(mcp_server, "_config", config)
|
|
monkeypatch.setattr(mcp_server, "_get_kg", lambda: kg)
|
|
|
|
def test_default_is_dry_run(self, monkeypatch, config, palace_path, kg):
|
|
from mempalace import mcp_server
|
|
|
|
self._patch(monkeypatch, config, kg)
|
|
client = chromadb.PersistentClient(path=palace_path)
|
|
client.get_or_create_collection("mempalace_drawers", metadata={"hnsw:space": "cosine"})
|
|
del client
|
|
|
|
report = mcp_server.tool_sync(project_dir=palace_path)
|
|
assert report["dry_run"] is True
|
|
|
|
def test_success_true_on_dry_run(self, monkeypatch, config, palace_path, kg):
|
|
"""Round-4: success path returns `success: True` for API symmetry
|
|
with the structured-error branches that all return `success: False`."""
|
|
from mempalace import mcp_server
|
|
|
|
self._patch(monkeypatch, config, kg)
|
|
client = chromadb.PersistentClient(path=palace_path)
|
|
client.get_or_create_collection("mempalace_drawers", metadata={"hnsw:space": "cosine"})
|
|
del client
|
|
|
|
report = mcp_server.tool_sync(project_dir=palace_path)
|
|
assert report.get("success") is True
|
|
assert report.get("dry_run") is True
|
|
|
|
def test_apply_true_is_destructive(self, monkeypatch, config, synced_world, kg):
|
|
from mempalace import mcp_server
|
|
|
|
# Rebuild config to point at synced_world's palace.
|
|
from mempalace.config import MempalaceConfig
|
|
import json
|
|
|
|
cfg_dir = Path(synced_world["palace_path"]).parent / "cfg_for_mcp_test"
|
|
cfg_dir.mkdir(parents=True, exist_ok=True)
|
|
with open(cfg_dir / "config.json", "w") as f:
|
|
json.dump({"palace_path": synced_world["palace_path"]}, f)
|
|
cfg = MempalaceConfig(config_dir=str(cfg_dir))
|
|
self._patch(monkeypatch, cfg, kg)
|
|
|
|
report = mcp_server.tool_sync(
|
|
project_dir=synced_world["repo_path"], apply=True, wing="demo"
|
|
)
|
|
assert report["dry_run"] is False
|
|
assert report["removed_drawers"] >= 1
|
|
|
|
def test_no_palace_returns_structured_error(self, monkeypatch, kg):
|
|
"""Round-3: tool_sync must keep the {success:False,error:...} contract
|
|
even on the early `_no_palace` short-circuit, not return the bare
|
|
legacy `{error,hint}` dict."""
|
|
from mempalace import mcp_server
|
|
|
|
class _EmptyConfig:
|
|
palace_path = ""
|
|
collection_name = "mempalace_drawers"
|
|
|
|
monkeypatch.setattr(mcp_server, "_config", _EmptyConfig())
|
|
monkeypatch.setattr(mcp_server, "_get_kg", lambda: kg)
|
|
|
|
result = mcp_server.tool_sync()
|
|
assert result.get("success") is False
|
|
assert "error" in result
|
|
|
|
def test_apply_without_scope_returns_structured_error(
|
|
self, monkeypatch, config, palace_path, kg
|
|
):
|
|
"""Round-2 P0: tool_sync must return {success: False, error: ...}
|
|
rather than letting ValueError propagate to the MCP client."""
|
|
from mempalace import mcp_server
|
|
|
|
client = chromadb.PersistentClient(path=palace_path)
|
|
client.get_or_create_collection("mempalace_drawers", metadata={"hnsw:space": "cosine"})
|
|
del client
|
|
|
|
self._patch(monkeypatch, config, kg)
|
|
result = mcp_server.tool_sync(apply=True) # no project_dir, no wing
|
|
assert result.get("success") is False
|
|
assert "wing=" in result.get("error", "") or "project_dirs" in result.get("error", "")
|
|
|
|
@pytest.mark.skipif(os.name == "nt", reason="fcntl-based contention test is POSIX only")
|
|
def test_lock_contention_returns_structured_error(self, monkeypatch, config, synced_world, kg):
|
|
"""Round-2 P0: tool_sync with apply=True under contention returns
|
|
a structured `{success: False, error: ...}` instead of raising."""
|
|
import fcntl
|
|
import hashlib
|
|
|
|
from mempalace import mcp_server
|
|
from mempalace.config import MempalaceConfig
|
|
import json
|
|
|
|
# Wire MCP config at synced_world.
|
|
cfg_dir = Path(synced_world["palace_path"]).parent / "cfg_for_lock_test"
|
|
cfg_dir.mkdir(parents=True, exist_ok=True)
|
|
with open(cfg_dir / "config.json", "w") as f:
|
|
json.dump({"palace_path": synced_world["palace_path"]}, f)
|
|
self._patch(monkeypatch, MempalaceConfig(config_dir=str(cfg_dir)), kg)
|
|
|
|
# Compute lock path the same way mine_palace_lock does.
|
|
resolved = os.path.realpath(os.path.expanduser(synced_world["palace_path"]))
|
|
palace_key = hashlib.sha256(os.path.normcase(resolved).encode()).hexdigest()[:16]
|
|
lock_dir = os.path.join(os.path.expanduser("~"), ".mempalace", "locks")
|
|
os.makedirs(lock_dir, exist_ok=True)
|
|
lock_path = os.path.join(lock_dir, f"mine_palace_{palace_key}.lock")
|
|
Path(lock_path).touch()
|
|
|
|
with open(lock_path, "r+") as lf:
|
|
fcntl.flock(lf, fcntl.LOCK_EX | fcntl.LOCK_NB)
|
|
try:
|
|
result = mcp_server.tool_sync(
|
|
project_dir=synced_world["repo_path"], wing="demo", apply=True
|
|
)
|
|
finally:
|
|
fcntl.flock(lf, fcntl.LOCK_UN)
|
|
|
|
assert result.get("success") is False
|
|
assert "another mine" in result.get("error", "").lower()
|
|
|
|
|
|
class TestSyncCli:
|
|
"""T1: `cmd_sync` argparse + dispatch wrapper round-trip."""
|
|
|
|
def test_dry_run_default_no_mutation(self, monkeypatch, tmp_dir, synced_world, capsys):
|
|
from mempalace import cli
|
|
|
|
argv = [
|
|
"mempalace",
|
|
"--palace",
|
|
synced_world["palace_path"],
|
|
"sync",
|
|
synced_world["repo_path"],
|
|
]
|
|
monkeypatch.setattr("sys.argv", argv)
|
|
cli.main()
|
|
|
|
captured = capsys.readouterr().out
|
|
assert "DRY RUN" in captured
|
|
assert "would remove" in captured
|
|
|
|
client, col = _open_drawers(synced_world["palace_path"])
|
|
try:
|
|
assert len(_drawer_ids(col)) == 6 # synced_world seeds 6, dry-run touches none
|
|
finally:
|
|
del client
|
|
|
|
def test_apply_flag_deletes(self, monkeypatch, tmp_dir, synced_world, capsys):
|
|
from mempalace import cli
|
|
|
|
argv = [
|
|
"mempalace",
|
|
"--palace",
|
|
synced_world["palace_path"],
|
|
"sync",
|
|
synced_world["repo_path"],
|
|
"--apply",
|
|
"--wing",
|
|
"demo",
|
|
]
|
|
monkeypatch.setattr("sys.argv", argv)
|
|
cli.main()
|
|
|
|
captured = capsys.readouterr().out
|
|
assert "Removed" in captured
|
|
assert "(removed)" in captured
|
|
|
|
client, col = _open_drawers(synced_world["palace_path"])
|
|
try:
|
|
survivors = _drawer_ids(col)
|
|
finally:
|
|
del client
|
|
assert survivors == {
|
|
"drawer_keep",
|
|
"drawer_no_source",
|
|
"drawer_out_of_scope",
|
|
}
|
|
|
|
def test_cli_emits_wal_on_apply(self, monkeypatch, synced_world):
|
|
"""F8 regression: cmd_sync must wire `_wal_log` so CLI deletes are
|
|
audited. Without this, scripted CLI invocations leave no trail."""
|
|
from mempalace import cli, mcp_server
|
|
|
|
seen = []
|
|
original = mcp_server._wal_log
|
|
|
|
def recording_wal(operation, params, result=None):
|
|
seen.append((operation, params, result))
|
|
original(operation, params, result)
|
|
|
|
monkeypatch.setattr(mcp_server, "_wal_log", recording_wal)
|
|
|
|
argv = [
|
|
"mempalace",
|
|
"--palace",
|
|
synced_world["palace_path"],
|
|
"sync",
|
|
synced_world["repo_path"],
|
|
"--apply",
|
|
"--wing",
|
|
"demo",
|
|
]
|
|
monkeypatch.setattr("sys.argv", argv)
|
|
cli.main()
|
|
|
|
ops = [op for op, _, _ in seen]
|
|
assert "sync_prune" in ops, f"CLI --apply did not emit WAL sync_prune entries; seen={ops}"
|
|
|
|
def test_apply_without_scope_exits_2(self, monkeypatch, synced_world, capsys):
|
|
"""F6 + F8 CLI hardening: --apply with no scope exits non-zero."""
|
|
from mempalace import cli
|
|
|
|
argv = [
|
|
"mempalace",
|
|
"--palace",
|
|
synced_world["palace_path"],
|
|
"sync",
|
|
"--apply",
|
|
]
|
|
monkeypatch.setattr("sys.argv", argv)
|
|
with pytest.raises(SystemExit) as exc_info:
|
|
cli.main()
|
|
assert exc_info.value.code == 2
|